Feature/SE integration #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> # Conflicts: # src/modules/module.hpp
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
# Conflicts: # src/loaders/loader.hpp
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
# Conflicts: # src/se/impl/common.hpp
iceseer
force-pushed
the
feature/se
branch
2 times, most recently
from
c710fe6 to
edaa255
Compare
iceseer
force-pushed
the
feature/se
branch
2 times, most recently
from
3d0fdf7 to
0cad2a2
Compare
[remove] configurator changes
xDimon
reviewed
Jun 5, 2025
| @@ -29,6 +40,9 @@ namespace jam::injector { | |||
| std::shared_ptr<app::Configuration> configuration); | |||
|
|
|||
| std::shared_ptr<app::Application> injectApplication(); | |||
| std::shared_ptr<Subscription> getSE(); | |||
xDimon
approved these changes
Jun 5, 2025
Harrm
reviewed
Jun 6, 2025
| using se_ptr = std::shared_ptr<Subscription>; | ||
| se_ptr se_; | ||
|
|
||
| SeHolder(se_ptr se); |
There was a problem hiding this comment.
What about copy, move constructors and assignment operators?
| @@ -41,14 +42,23 @@ namespace jam::metrics { | |||
|
|
|||
| namespace jam::app { | |||
|
|
|||
| struct SeHolder final { | |||
| using se_ptr = std::shared_ptr<Subscription>; | |||
There was a problem hiding this comment.
Suggested change
| using se_ptr = std::shared_ptr<Subscription>; | |
| using SePtr = std::shared_ptr<Subscription>; |
To match existing naming case.
|
|
||
| # Set C++ standard | ||
| target_compile_features(${MODULE} PRIVATE | ||
| cxx_std_20 |
|
|
||
| namespace jam::se { | ||
|
|
||
| struct IDispatcher { |
There was a problem hiding this comment.
I don't think we have a convention to prefix interfaces with "I"?
| std::thread::id id_; | ||
|
|
||
| private: | ||
| inline void checkLocked() { |
There was a problem hiding this comment.
Suggested change
| inline void checkLocked() { | |
| void checkLocked() { |
|
|
||
| return std::chrono::microseconds(0ull); | ||
| } | ||
| return std::chrono::minutes(10ull); |
Comment on lines
+149
to
+150
| } catch (...) { | ||
| } |
Comment on lines
+165
to
+166
| std::lock_guard lock(tasks_cs_); | ||
| return is_busy_; |
There was a problem hiding this comment.
Suggested change
| std::lock_guard lock(tasks_cs_); | |
| return is_busy_; | |
| std::lock_guard lock(tasks_cs_); | |
| return is_busy_; |
Why is accessing is_busy_ require locking tasks_cs_? I suspect this relation can be easily broken with future refactors since it's pretty unintuitive, what about SafeObject?
|
|
||
| namespace jam::se { | ||
|
|
||
| struct IDisposable { |
| template <typename... Args> | ||
| static constexpr EngineHash getSubscriptionHash() { | ||
| #ifdef _WIN32 | ||
| constexpr EngineHash value = CT_MURMUR2(__FUNCSIG__); |
There was a problem hiding this comment.
Maybe add a separate macro for this? I think it's going to be useful in several places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.